⚒️ Adjust the appearance of the toolbar on mobile devices #356
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FunamaYukina
force-pushed
the
adjust-the-appearance-of-the-toolbar-on-mobile-devices
branch
from
045ff22 to
da9da9b
Compare
FunamaYukina
commented
Dec 23, 2024
| @@ -18,7 +18,7 @@ | |||
|
|
|||
| .main { | |||
| width: 100%; | |||
| height: 100%; | |||
| height: calc(100svh - var(--default-header-height)); | |||
There was a problem hiding this comment.
I tried using vh instead of svh, but it didn't display correctly, so I went back to using svh.
FunamaYukina
requested review from
hoshinotsuyoshi,
junkisai,
MH4GF and
sasamuku
and removed request for
a team
MH4GF
requested changes
Dec 23, 2024
FunamaYukina
force-pushed
the
adjust-the-appearance-of-the-toolbar-on-mobile-devices
branch
from
da9da9b to
f920385
Compare
FunamaYukina
force-pushed
the
adjust-the-appearance-of-the-toolbar-on-mobile-devices
branch
from
f920385 to
e3faa74
Compare
|
@MH4GF preview: https://liam-erd-sample-bkbqls58u-route-06-core.vercel.app/
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've resolved the problem of the missing toolbar on mobile browsers.
Preview: https://liam-erd-sample-acagd5sze-route-06-core.vercel.app/
Related Issue
Changes
(Safari)
(Chrome)
I've checked on Firefox🔥 and Brave🦁 as well, and there seems to be no issue.
Testing
Other Information