💄 Update font-family settings across ERD Renderer components
#352
+17
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For browsers other than Google Chrome
hoshinotsuyoshi
changed the title
font-family settings across ERD Renderer componentsfont-family settings across ERD Renderer components
- Remove redundant `font-family` settings from various components
hoshinotsuyoshi
force-pushed
the
web-font-inter
branch
from
81d1f9c to
28a9eb2
Compare
hoshinotsuyoshi
requested review from
FunamaYukina,
junkisai,
MH4GF and
sasamuku
and removed request for
a team
MH4GF
approved these changes
Dec 23, 2024
| @@ -5,6 +5,8 @@ | |||
| /* NOTE: workaround for that drawer with modal={false} does not work */ | |||
| /* ref: https://github.com/emilkowalski/vaul/issues/492 */ | |||
| pointer-events: all; | |||
|
|
|||
| font-family: var(--main-font); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fully applied the
Interfont-family throughout.safari:
Related Issue
Changes
Inter.font-familysetting insrc/components/ERDRenderer/**/*.font-familysettings to Radix-originated toolbar.font-familysettings to Vaul-originated drawer.Description
Changes
3.and4.were necessary due to the relatively higher DOM hierarchy of the Toolbar and Drawer withinsrc/components/ERDRenderer, requiring specific adjustments for these components. For change3, I used a global setting. As noted in the CSS comments, I heavily referenced the information from Radix's issue radix-ui/primitives#2908.Testing
Other Information