fix: Fixed problem with active tables not being highlighted in LeftPane when opened via query parameter #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne when opened via query parameter
MH4GF
force-pushed
the
fix-first-load-highlighting-left-pane
branch
from
e877917 to
bc2118d
Compare
MH4GF
commented
Dec 20, 2024
| @@ -13,9 +13,6 @@ type Props = { | |||
| } | |||
|
|
|||
| export const TableNameMenuButton: FC<Props> = ({ node }) => { | |||
| const { | |||
| active: { tableName }, | |||
| } = useUserEditingStore() | |||
There was a problem hiding this comment.
I've hit the bug a few times, and it seems this one may not re-render. 💭
MH4GF
requested review from
hoshinotsuyoshi,
FunamaYukina,
junkisai and
sasamuku
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024-12-20.17.57.32.mov