Set envName(production or preview) to cliVersion
#343
Merged
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoshinotsuyoshi
force-pushed
the
pass-branch-name-to-react-component
branch
from
a672599 to
8eb12f6
Compare
hoshinotsuyoshi
changed the title
production or preview) to React component
Integrates the current envName(production/preview) into cliVersion
hoshinotsuyoshi
force-pushed
the
pass-branch-name-to-react-component
branch
from
8eb12f6 to
afdad64
Compare
hoshinotsuyoshi
changed the title
production or preview) to React componentproduction or preview) to cliVersion
hoshinotsuyoshi
requested review from
FunamaYukina,
junkisai,
MH4GF and
sasamuku
and removed request for
a team
MH4GF
approved these changes
Dec 20, 2024
Comment on lines
+71
to
+73
| // The main branch is considered production, all other branches are treated as previews. | ||
| // This alignment is done to match the deployment settings to Vercel specified in .github/workflows. | ||
| const envName = gitBranch === 'main' ? 'production' : 'preview' |
There was a problem hiding this comment.
I'm not sure if I should write about it here, since it's information only our team uses.
But once it's done, it looks good!
There was a problem hiding this comment.
Indeed, there seems to be some merit to that opinion! :) I believe managing the envName value within the CLI package is necessary for our team's dogfooding. Conversely, it might be a good idea to move this // comment to the .github/workflows side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integrates the current envName(
productionorpreview) into the React component's environment variables.There is no change to the visual behavior of the ERD HTML.
Related Issue
Changes
Testing
In local , make this diff
and
pnpm dev,I found that
envNameset tocliVersionOther Information