Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hidden nodes can now be reflected from query parameters #327

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

MH4GF
Copy link
Member

@MH4GF MH4GF commented Dec 19, 2024

hidden nodes can now be reflected from query parameters!

2024-12-19.19.02.02.mov

As a side effect, the hidden information can now be maintained even if the showMode is changed 👍🏻

However, the URL looks a little bad, as following:

https://liam-erd-sample-a6smzxm8k-route-06-core.vercel.app/?hidden=account_aliases%2Caccount_conversations%2Caccount_deletion_requests%2Caccount_domain_blocks%2Caccount_migrations%2Caccount_moderation_notes%2Caccount_notes%2Caccount_pins%2Caccount_relationship_severance_events%2Caccount_stats%2Caccount_statuses_cleanup_policies%2Caccount_warning_presets%2Caccount_warnings%2Caccounts%2Caccounts_tags%2Cadmin_action_logs%2Cannouncement_mutes%2Cannouncement_reactions%2Cannouncements%2Cannual_report_statuses_per_account_counts%2Cappeals%2Cbackups%2Cblocks%2Cbookmarks%2Cbulk_import_rows%2Cbulk_imports%2Ccanonical_email_blocks%2Cconversation_mutes%2Cconversations%2Ccustom_emoji_categories%2Ccustom_emojis%2Ccustom_filter_keywords%2Ccustom_filter_statuses%2Ccustom_filters%2Cdomain_allows%2Cdomain_blocks%2Cemail_domain_blocks%2Cfavourites%2Cfeatured_tags%2Cfollow_recommendation_mutes%2Cfollow_recommendation_suppressions%2Cfollow_requests%2Cfollows%2Cgenerated_annual_reports%2Cidentities%2Cimports%2Cinvites%2Cip_blocks%2Clist_accounts%2Clists%2Clogin_activities%2Cmarkers%2Cmedia_attachments%2Cmentions%2Cmutes%2Cnotification_permissions%2Cnotification_policies%2Cnotification_requests%2Cnotifications%2Coauth_access_grants%2Coauth_access_tokens%2Coauth_applications%2Cpghero_space_stats%2Cpoll_votes%2Cpolls%2Cpreview_card_providers%2Cpreview_card_trends%2Cpreview_cards%2Cpreview_cards_statuses%2Crelationship_severance_events%2Crelays%2Creport_notes%2Creports%2Crules%2Cscheduled_statuses%2Csession_activations%2Csettings%2Csevered_relationships%2Csite_uploads%2Csoftware_updates%2Cstatus_edits%2Cstatus_pins%2Cstatus_stats%2Cstatus_trends%2Cstatuses%2Cstatuses_tags%2Ctag_follows%2Ctag_trends%2Ctags%2Cterms_of_services%2Ctombstones%2Cunavailable_domains%2Cuser_invite_requests%2Cweb_push_subscriptions%2Cweb_settings%2Cwebauthn_credentials%2Cwebhooks

It may be possible to compress using CompressionStream. This will be considered for support in the next PR.

ref:

@MH4GF MH4GF changed the title hidden nodes from query parameter feat: hidden nodes can now be reflected from query parameters Dec 19, 2024
@MH4GF MH4GF marked this pull request as ready for review December 19, 2024 10:01
@MH4GF MH4GF requested a review from a team as a code owner December 19, 2024 10:01
@MH4GF MH4GF requested review from hoshinotsuyoshi, FunamaYukina, junkisai and sasamuku and removed request for a team December 19, 2024 10:01
Copy link
Member

@sasamuku sasamuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really useful!!
LGTM🚀

@sasamuku
Copy link
Member

It may be possible to compress using CompressionStream. This will be considered for support in the next PR.

👍👍

@sasamuku sasamuku added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit d993117 Dec 19, 2024
13 checks passed
@sasamuku sasamuku deleted the hidden-nodes-from-query-parameter branch December 19, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants