📈 Add click logging for toolbar actions and include show mode in even… #326
Conversation
FunamaYukina
force-pushed
the
add-custom-log-on-ToolBar
branch
from
f6b3faf to
eca61e9
Compare
FunamaYukina
requested review from
hoshinotsuyoshi,
junkisai,
MH4GF and
sasamuku
and removed request for
a team
| export const clickLogEvent = ({ | ||
| element, | ||
| zoomLevel, | ||
| showMode, | ||
| }: ClickLogEvent) => { | ||
| pushToDataLayer({ | ||
| event: 'click', | ||
| element, | ||
| zoomLevel, | ||
| showMode, |
There was a problem hiding this comment.
Regarding the toolbar operations, since the design was to record the operations in a log called "toolbarAction", I would like you to create a separate function such as toolbarActionLogEvent(). 🙏
There was a problem hiding this comment.
I apologize for the mistake😱.
I've revised the code, so please check it again🙏.
582ac0e
FunamaYukina
force-pushed
the
add-custom-log-on-ToolBar
branch
from
eca61e9 to
582ac0e
Compare
|
|
||
| const handleClick = useCallback(() => { | ||
| toolbarActionLogEvent({ | ||
| element: 'fitview', | ||
| showMode: showMode, |
There was a problem hiding this comment.
[nits]
| showMode: showMode, | |
| showMode, |
| const handleClick = useCallback(() => { | ||
| toolbarActionLogEvent({ | ||
| element: 'tidyUp', | ||
| showMode: showMode, |
There was a problem hiding this comment.
[nits]
| showMode: showMode, | |
| showMode, |
| toolbarActionLogEvent({ | ||
| element: 'zoom', | ||
| zoomLevel: zoomLevel.toFixed(2), | ||
| showMode: showMode, |
There was a problem hiding this comment.
[nits]
| showMode: showMode, | |
| showMode, |
| toolbarActionLogEvent({ | ||
| element: 'zoom', | ||
| zoomLevel: zoomLevel.toFixed(2), | ||
| showMode: showMode, |
There was a problem hiding this comment.
[nits]
| showMode: showMode, | |
| showMode, |
There was a problem hiding this comment.
Thank you🙏!
I've addressed all three of the points raised.↑
Fixed: 932ce82
| showMode, | ||
| }: ToolbarActionLogEvent) => { | ||
| pushToDataLayer({ | ||
| event: 'click', |
There was a problem hiding this comment.
I want to set the event in the toolbarActionLogEvent() function to 'toolbarAction'!
| event: 'click', | |
| event: 'toolbarAction', |
There was a problem hiding this comment.
Summary
📈 Add click logging for toolbar actions and include show mode in event data.
Testing
(-)
(+)
Other Information