Restored columnType visibility #290
Conversation
FunamaYukina
requested review from
hoshinotsuyoshi,
junkisai,
MH4GF and
sasamuku
and removed request for
a team
| @@ -48,7 +48,7 @@ | |||
| transition: opacity 300ms var(--default-timing-function); | |||
| } | |||
|
|
|||
| .wrapper:hover .columnType { | |||
There was a problem hiding this comment.
Let me know why this is not working ?👀
There was a problem hiding this comment.
I didn't know about that either, but I've just been informed(Mr. Miyagi told me).
You're attempting to access a class named "columnType" from TableNode,
TableNode.module.css
.wrapper:hover .columnType {
opacity: 1;
}
but the real class name is obfuscated. (it is not columnType)
As a result, you couldn't reference the class from another file. I've resolved this by utilizing the data attribute and global:.
ref: 296fdaa
There was a problem hiding this comment.
Thank you for explaining.
data-* attributes can be used in that situation, I see 👍
There was a problem hiding this comment.
Yes😆 This time, we were able to fix the issue by only modifying the CSS.
FunamaYukina
force-pushed
the
Restored-columnType-visibility
branch
from
dfac2c6 to
296fdaa
Compare
|
@MH4GF commit: 296fdaa preview: https://liam-erd-sample-6h1szphmk-route-06-core.vercel.app/ |
Summary
Resolved the problem that prevented the column type from being shown on TableNode hover.
Before
After
Related Issue
Changes
Testing
Other Information
In contrast to the design, where column types are shown for all relevant TableNodes on hover, this implementation displays the column type only for the hovered TableNode.（In order to fix the bug quickly.）