Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Minor refactoring of ERDContent #287

Merged
merged 3 commits into from
Dec 17, 2024
Merged

refactor: Minor refactoring of ERDContent #287

merged 3 commits into from
Dec 17, 2024
+24 −35

Conversation

MH4GF
Copy link
Member

@MH4GF MH4GF commented Dec 17, 2024

  • refactor: Unified showmode invocation
  • refactor: Extract edge highlighting logic into reusable functions

@MH4GF MH4GF had a problem deploying to preview - @liam-hq/erd-sample December 17, 2024 05:43 — with GitHub Actions Error
@MH4GF MH4GF changed the title refactor table node refactor: Minor refactoring of ERDContent Dec 17, 2024
@MH4GF MH4GF marked this pull request as ready for review December 17, 2024 05:47
@MH4GF MH4GF requested a review from a team as a code owner December 17, 2024 05:47
@MH4GF MH4GF requested review from hoshinotsuyoshi, FunamaYukina, junkisai and sasamuku and removed request for a team December 17, 2024 05:47
hoshinotsuyoshi
hoshinotsuyoshi approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@hoshinotsuyoshi hoshinotsuyoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@hoshinotsuyoshi hoshinotsuyoshi added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 710b457 Dec 17, 2024
12 checks passed
@hoshinotsuyoshi hoshinotsuyoshi deleted the refactor-table-node branch December 17, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoshinotsuyoshi hoshinotsuyoshi hoshinotsuyoshi approved these changes

@FunamaYukina FunamaYukina Awaiting requested review from FunamaYukina FunamaYukina is a code owner automatically assigned from liam-hq/liam-dev

@junkisai junkisai Awaiting requested review from junkisai junkisai is a code owner automatically assigned from liam-hq/liam-dev

@sasamuku sasamuku Awaiting requested review from sasamuku sasamuku is a code owner automatically assigned from liam-hq/liam-dev

Assignees

@MH4GF MH4GF

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MH4GF @hoshinotsuyoshi