Highlight related edges and cardinalities when a TableNode is active. #284
Conversation
FunamaYukina
force-pushed
the
highlight-related-edges-and-cardinalities-when-a-TableNode-is-active
branch
from
a7674be to
b08232b
Compare
FunamaYukina
requested review from
hoshinotsuyoshi,
junkisai,
MH4GF and
sasamuku
and removed request for
a team
frontend/packages/erd-core/src/components/ERDRenderer/ERDContent/TableNode/type.ts
Outdated
Show resolved
Hide resolved
| @@ -65,47 +65,66 @@ export const ERDContentInner: FC<Props> = ({ | |||
| const { | |||
| state: { loading }, | |||
| } = useERDContentContext() | |||
| const [clickedNodeId, setClickedNodeId] = useState<string | null>(null) | |||
There was a problem hiding this comment.
It is painful to have to create a separate state from the active state managed by useUserEditingStore(), but it seems that the logic has to be unravelled to solve the problem. I'd like to try another PR.
There was a problem hiding this comment.
You're absolutely right. I wanted to write the code more simply, but I couldn't. In the end, the code became more complex🥲.Thank you for thinking about it🙏.
| @@ -65,47 +65,66 @@ export const ERDContentInner: FC<Props> = ({ | |||
| const { | |||
| state: { loading }, | |||
| } = useERDContentContext() | |||
| const [clickedNodeId, setClickedNodeId] = useState<string | null>(null) | |||
There was a problem hiding this comment.
I've been considering the following:
Is click a suitable naming? Perhaps something like active might be better.
There was a problem hiding this comment.
I agree that it is painful. I was thinking about checking whether the changes we made to how we handle data around PR #280 could be utilized. The functionality seems good, so I think it's fine to merge it now and integrate later!
There was a problem hiding this comment.
Thank you for your suggestion! I agree!
I've fixed it. 9c8767e
|
Thank you all for your reviews.🙏 |
FunamaYukina
deleted the
highlight-related-edges-and-cardinalities-when-a-TableNode-is-active
branch
Summary
Highlight related edges and cardinalities when a TableNode is active.
Preview: https://liam-erd-sample-gx3t0p2yn-route-06-core.vercel.app/
Before
After
Related Issue
Changes
Testing
Other Information