Optimize TableColumn component by caching relationship checks #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced useMemo to cache `isSource` and `targetCardinality` computations.
hoshinotsuyoshi
force-pushed
the
optimize-table-column-component
branch
from
b1c1aa6 to
f843a99
Compare
hoshinotsuyoshi
requested review from
FunamaYukina,
junkisai,
MH4GF and
sasamuku
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Optimize TableColumn component by caching relationship checks.
Introduced useMemo to cache
isSourceandtargetCardinalitycomputations.Experiment
Triggered
handleMouseLeaveNodemanually on the accounts table node to measure performance impact.Demo
2024-12-16.18.45.55.mov
1.
ERDContentInnerbefore: ~660 ms
after: ~170 ms
2.
TableColumn:account_aliasestable >idcolumnbefore: ~0.6 ms
after: ~0.1 ms
Testing
N/A
Other Information
N/A