fix: Fixed an issue where URL sharing in TableDetail sometimes did not work correctly #276
+14
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MH4GF
force-pushed
the
fix-table-detail
branch
from
7241265 to
a85acb3
Compare
MH4GF
commented
Dec 16, 2024
Comment on lines
+5
to
+6
| export const useUserEditingActiveStore = () => | ||
| useSnapshot(userEditingStore.active) |
There was a problem hiding this comment.
If this was not done, there was a problem with it not re-rendering. 🤔
MH4GF
commented
Dec 16, 2024
| } = useUserEditingStore() | ||
| const { tableName } = useUserEditingActiveStore() | ||
| const { tables } = useDBStructureStore() | ||
| const open = Object.keys(tables).length > 0 && tableName !== undefined |
There was a problem hiding this comment.
Had to wait if loading was complete from schema.json.
MH4GF
requested review from
hoshinotsuyoshi,
FunamaYukina,
junkisai and
sasamuku
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature to open TableDetail when opened with a URL with a query parameter did not work in some cases, which will be corrected.
https://liam-erd-sample-pzarkcxaz-route-06-core.vercel.app/?active=featured_tags