fix: Fixed an issue where the correct table was not focused when sharing URLs in TableDetail #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r layout management
…ing URLs in TableDetail
MH4GF
force-pushed
the
fix-initialize-nodes
branch
from
896111e to
19e499a
Compare
MH4GF
commented
Dec 16, 2024
| const visibleNodes: Node[] = nodes.filter((node) => !node.hidden) | ||
| const hiddenNodes: Node[] = nodes.filter((node) => node.hidden) | ||
| const handleLayout = useCallback( | ||
| async (fitViewOptions?: FitViewOptions) => { |
There was a problem hiding this comment.
📝 It is only possible to pass fitViewOptions.
MH4GF
commented
Dec 16, 2024
| const tableName = urlParams.get(activeQueryParam) | ||
|
|
||
| return tableName || undefined | ||
| } |
There was a problem hiding this comment.
📝 The contents of useActiveTableNameFromUrl() have been brought in.
MH4GF
changed the title
MH4GF
requested review from
hoshinotsuyoshi,
FunamaYukina,
junkisai and
sasamuku
and removed request for
a team
| const tableNameFromUrl = getActiveTableNameFromUrl() | ||
| updateActiveTableName(tableNameFromUrl) | ||
| const fitViewOptions = tableNameFromUrl | ||
| ? { maxZoom: 1, duration: 300, nodes: [{ id: tableNameFromUrl }] } |
There was a problem hiding this comment.
📝 same as useFitViewWhenActiveTableChange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024-12-16.21.13.30.mov
ref: https://liam-erd-sample-5rp1jfv9b-route-06-core.vercel.app/?active=account_statuses_cleanup_policies