Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the highlight on Edge hover to prevent performance degradation #273

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

MH4GF
Copy link
Member

@MH4GF MH4GF commented Dec 16, 2024

The highlighting of single edges is removed as a feature as it does not contribute to the readability of the ER diagram.
This is motivated by the need to reduce the re-rendering that occurs when moving on the canvas.

Before

2024-12-16.17.18.37.mov

After

2024-12-16.17.21.22.mov

Testing

npx react-scan@latest https://liam-erd-sample-gz7pse1m5-route-06-core.vercel.app/

Copy link

changeset-bot bot commented Dec 16, 2024

⚠️ No Changeset found

Latest commit: 1ba3f4a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MH4GF MH4GF force-pushed the remove-hovering-edges-effect branch from 1ba3f4a to d255ff3 Compare December 16, 2024 08:23
@MH4GF MH4GF marked this pull request as ready for review December 16, 2024 08:24
@MH4GF MH4GF requested a review from a team as a code owner December 16, 2024 08:24
@MH4GF MH4GF requested review from hoshinotsuyoshi, FunamaYukina, junkisai and sasamuku and removed request for a team December 16, 2024 08:24
Copy link
Member

@FunamaYukina FunamaYukina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that your idea is a promising approach to improving performance👍.

@FunamaYukina FunamaYukina added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 533a876 Dec 16, 2024
12 checks passed
@FunamaYukina FunamaYukina deleted the remove-hovering-edges-effect branch December 16, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants