Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responsive support for Top #27

Merged
merged 11 commits into from
Oct 9, 2024
Merged

Responsive support for Top #27

merged 11 commits into from
Oct 9, 2024
+349 −76

Conversation

kumanoayumi
Copy link
Member

@kumanoayumi kumanoayumi commented Oct 9, 2024 •
edited
Loading

Summary

Responsive support to the top of the page.

Related Issue

Changes

  • Setup the staticDirs to storybook for use public image assets.
  • Update TopCards component storybook.
  • Setup viewport for responsive layout.
  • Adjust grid layout for tablet and mobile views.

Testing

Other Information

@kumanoayumi kumanoayumi self-assigned this Oct 9, 2024
@kumanoayumi kumanoayumi temporarily deployed to preview - service-site October 9, 2024 02:13 — with GitHub Actions Inactive
@kumanoayumi kumanoayumi temporarily deployed to preview - service-site-storybook October 9, 2024 02:13 — with GitHub Actions Inactive
@kumanoayumi kumanoayumi marked this pull request as ready for review October 9, 2024 02:16
@kumanoayumi kumanoayumi requested a review from a team as a code owner October 9, 2024 02:16
@kumanoayumi kumanoayumi requested review from hoshinotsuyoshi, FunamaYukina, junkisai, MH4GF and sasamuku and removed request for a team October 9, 2024 02:16
@MH4GF
Copy link
Member

MH4GF commented Oct 9, 2024

@kumanoayumi Please check CI fails.

@kumanoayumi kumanoayumi temporarily deployed to preview - service-site October 9, 2024 02:39 — with GitHub Actions Inactive
@kumanoayumi kumanoayumi temporarily deployed to preview - service-site-storybook October 9, 2024 02:39 — with GitHub Actions Inactive
MH4GF
MH4GF approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@MH4GF MH4GF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!! 🚀

frontend/apps/service-site/src/app/layout.tsx
export const viewport: Viewport = {
width: 'device-width',
initialScale: 1,
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@kumanoayumi kumanoayumi temporarily deployed to preview - service-site October 9, 2024 02:44 — with GitHub Actions Inactive
@kumanoayumi kumanoayumi temporarily deployed to preview - service-site-storybook October 9, 2024 02:44 — with GitHub Actions Inactive
@kumanoayumi kumanoayumi temporarily deployed to preview - service-site October 9, 2024 02:48 — with GitHub Actions Inactive
@kumanoayumi kumanoayumi temporarily deployed to preview - service-site-storybook October 9, 2024 02:48 — with GitHub Actions Inactive
@junkisai
Copy link
Member

junkisai commented Oct 9, 2024 •
edited
Loading

@kumanoayumi
The issue causing the CI failure has been addressed in this PR. 🙏
#28

@kumanoayumi
Copy link
Member Author

@junkisai Thank you for the correction, I will take it in as soon as it has merged!

@junkisai
Copy link
Member

junkisai commented Oct 9, 2024

@kumanoayumi
I've just merged this PR, so please try pulling the latest main branch and incorporating those changes!

@kumanoayumi kumanoayumi temporarily deployed to preview - service-site October 9, 2024 02:59 — with GitHub Actions Inactive
@kumanoayumi kumanoayumi temporarily deployed to preview - service-site-storybook October 9, 2024 02:59 — with GitHub Actions Inactive
@kumanoayumi
Copy link
Member Author

@junkisai Thank you so much ✨

@kumanoayumi kumanoayumi temporarily deployed to preview - service-site October 9, 2024 03:03 — with GitHub Actions Inactive
@kumanoayumi kumanoayumi temporarily deployed to preview - service-site-storybook October 9, 2024 03:03 — with GitHub Actions Inactive
@kumanoayumi kumanoayumi temporarily deployed to preview - service-site October 9, 2024 03:09 — with GitHub Actions Inactive
@kumanoayumi kumanoayumi temporarily deployed to preview - service-site-storybook October 9, 2024 03:09 — with GitHub Actions Inactive
@kumanoayumi
Copy link
Member Author

@MH4GF
Thank you very much for the swift review 🙏 🤩.
I've passed CI and will merge.

@kumanoayumi kumanoayumi merged commit cd6dfba into main Oct 9, 2024
6 checks passed
@kumanoayumi kumanoayumi deleted the 2672/top-responsive branch October 9, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MH4GF MH4GF MH4GF approved these changes

@hoshinotsuyoshi hoshinotsuyoshi Awaiting requested review from hoshinotsuyoshi hoshinotsuyoshi was automatically assigned from route06inc/liam-dev

@FunamaYukina FunamaYukina Awaiting requested review from FunamaYukina FunamaYukina was automatically assigned from route06inc/liam-dev

@junkisai junkisai Awaiting requested review from junkisai junkisai was automatically assigned from route06inc/liam-dev

@sasamuku sasamuku Awaiting requested review from sasamuku sasamuku was automatically assigned from route06inc/liam-dev

Assignees

@kumanoayumi kumanoayumi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumanoayumi @MH4GF @junkisai