Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance: replace contentlayer to contentlayer2 #26

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

MH4GF
Copy link
Member

@MH4GF MH4GF commented Oct 8, 2024

I migrate contentlayer to https://github.com/timlrx/contentlayer2 .

Background

To run lint with CI, you need to run contentlayer build beforehand. However, when I run it, I get the following error:

Currently contentlayer is not maintained and a forked version of the community is maintained.
This issue could not be resolved without a forked version, so I migrated.

To run lint with CI, you need to run `contentlayer build` beforehand. However, when I run it, I get the following error:

- contentlayerdev/contentlayer#495

Currently contentlayer is not maintained and a forked version of the community is maintained.
This issue could not be resolved without a forked version, so I migrated.
@MH4GF MH4GF temporarily deployed to preview - service-site October 8, 2024 10:32 — with GitHub Actions Inactive
@MH4GF MH4GF temporarily deployed to preview - service-site-storybook October 8, 2024 10:32 — with GitHub Actions Inactive
@@ -8,6 +8,8 @@
"dev:storybook": "storybook dev -h localhost -p 6006 --no-open",
"build": "next build",
"build:storybook": "storybook build",
"gen": "conc -c auto pnpm:gen:*",
"gen:contentlayer": "contentlayer2 build",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I wanted to do was this.

@MH4GF MH4GF marked this pull request as ready for review October 8, 2024 10:38
@MH4GF MH4GF requested a review from a team as a code owner October 8, 2024 10:38
@MH4GF MH4GF requested review from hoshinotsuyoshi, FunamaYukina, junkisai and sasamuku and removed request for a team October 8, 2024 10:38
Copy link
Member

@junkisai junkisai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't previously aware of this problem. 👀

> Conflicts:
>	frontend/apps/service-site/package.json
>	frontend/pnpm-lock.yaml
@MH4GF MH4GF temporarily deployed to preview - service-site October 9, 2024 02:43 — with GitHub Actions Inactive
@MH4GF MH4GF temporarily deployed to preview - service-site-storybook October 9, 2024 02:43 — with GitHub Actions Inactive
@MH4GF MH4GF merged commit d79954d into main Oct 9, 2024
2 of 5 checks passed
@MH4GF MH4GF deleted the replace-to-contentlayer2 branch October 9, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants