refactor: Replace duplicate code with common components #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junkisai
temporarily deployed
to
preview - service-site
GitHub Actions
Inactive
junkisai
temporarily deployed
to
preview - service-site-storybook
GitHub Actions
Inactive
junkisai
changed the title
junkisai
requested review from
hoshinotsuyoshi,
FunamaYukina,
MH4GF and
sasamuku
and removed request for
a team
junkisai
force-pushed
the
refactor/duplicate-component
branch
from
e00e599 to
b8e3623
Compare
junkisai
temporarily deployed
to
preview - service-site
GitHub Actions
Inactive
junkisai
temporarily deployed
to
preview - service-site-storybook
GitHub Actions
Inactive
junkisai
force-pushed
the
refactor/duplicate-component
branch
from
b8e3623 to
fea31a7
Compare
junkisai
temporarily deployed
to
preview - service-site
GitHub Actions
Inactive
junkisai
temporarily deployed
to
preview - service-site-storybook
GitHub Actions
Inactive
junkisai
force-pushed
the
refactor/duplicate-component
branch
from
fea31a7 to
d959c3c
Compare
junkisai
temporarily deployed
to
preview - service-site
GitHub Actions
Inactive
junkisai
temporarily deployed
to
preview - service-site-storybook
GitHub Actions
Inactive
junkisai
force-pushed
the
refactor/duplicate-component
branch
from
d959c3c to
0a8f8d7
Compare
junkisai
temporarily deployed
to
preview - service-site
GitHub Actions
Inactive
junkisai
temporarily deployed
to
preview - service-site-storybook
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
By implementing multilingual support（ref. #16 ）, we've encountered cases where different page paths display the same content. Previously, these were managed with separate code blocks. I appreciate that you've now consolidated them into a single location.
Related Issue
Changes
Testing
Other Information