Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use org.eclipse.elk.layered in elk.algorithm #214

Merged
merged 5 commits into from
Dec 12, 2024
Merged

feat: use org.eclipse.elk.layered in elk.algorithm #214

merged 5 commits into from
Dec 12, 2024

Conversation

junkisai
Copy link
Member

@junkisai junkisai commented Dec 11, 2024 •
edited
Loading

Summary

I have adopted the ELK Layered algorithm for automatic layout.
Additionally, I have implemented a "Table Name" mode.

2024-12-12.12.17.17.mov

Changes

Testing

Other Information

@junkisai junkisai temporarily deployed to preview - erd-sample December 11, 2024 07:42 — with GitHub Actions Inactive
@junkisai junkisai temporarily deployed to preview - erd-sample December 12, 2024 03:16 — with GitHub Actions Inactive
@junkisai junkisai marked this pull request as ready for review December 12, 2024 04:46
@junkisai junkisai requested a review from a team as a code owner December 12, 2024 04:46
@junkisai junkisai requested review from hoshinotsuyoshi, FunamaYukina, MH4GF and sasamuku and removed request for a team December 12, 2024 04:46
MH4GF
MH4GF approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@MH4GF MH4GF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Awesome work!!

.../src/components/ERDRenderer/ERDContent/TableNode/TableDetail/RelatedTables/RelatedTables.tsx
const { nodes, edges } = convertDBStructureToNodes(extractedDBStructure)
const { nodes, edges } = convertDBStructureToNodes({
dbStructure: extractedDBStructure,
showMode: 'TABLE_NAME',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@MH4GF MH4GF added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit a155377 Dec 12, 2024
12 checks passed
@MH4GF MH4GF deleted the feat/layerd-option branch December 12, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MH4GF MH4GF MH4GF approved these changes

@hoshinotsuyoshi hoshinotsuyoshi Awaiting requested review from hoshinotsuyoshi hoshinotsuyoshi is a code owner automatically assigned from liam-hq/liam-dev

@FunamaYukina FunamaYukina Awaiting requested review from FunamaYukina FunamaYukina is a code owner automatically assigned from liam-hq/liam-dev

@sasamuku sasamuku Awaiting requested review from sasamuku sasamuku is a code owner automatically assigned from liam-hq/liam-dev

Assignees

@junkisai junkisai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junkisai @MH4GF