Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace Comment div with DrawerDescription component and add aria-describedby for accessibility #208

Merged
merged 1 commit into from
Dec 11, 2024
Merged

feat: replace Comment div with DrawerDescription component and add aria-describedby for accessibility #208

merged 1 commit into from
Dec 11, 2024

Conversation

MH4GF
Copy link
Member

@MH4GF MH4GF commented Dec 11, 2024 •
edited
Loading

I've fixed following error:

Image

@MH4GF MH4GF temporarily deployed to preview - erd-sample December 11, 2024 06:20 — with GitHub Actions Inactive
@MH4GF MH4GF marked this pull request as ready for review December 11, 2024 06:21
@MH4GF MH4GF requested a review from a team as a code owner December 11, 2024 06:21
@MH4GF MH4GF requested review from hoshinotsuyoshi, FunamaYukina, junkisai and sasamuku and removed request for a team December 11, 2024 06:21
junkisai
junkisai approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@junkisai junkisai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that using DrawerDescription can solve the issue!

@MH4GF MH4GF added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit d0a63b8 Dec 11, 2024
13 checks passed
@MH4GF MH4GF deleted the fix-aria-described-by branch December 11, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junkisai junkisai junkisai approved these changes

@hoshinotsuyoshi hoshinotsuyoshi Awaiting requested review from hoshinotsuyoshi hoshinotsuyoshi is a code owner automatically assigned from liam-hq/liam-dev

@FunamaYukina FunamaYukina Awaiting requested review from FunamaYukina FunamaYukina is a code owner automatically assigned from liam-hq/liam-dev

@sasamuku sasamuku Awaiting requested review from sasamuku sasamuku is a code owner automatically assigned from liam-hq/liam-dev

Assignees

@MH4GF MH4GF

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MH4GF @junkisai