Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows ninja build failed #103

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix windows ninja build failed #103

merged 1 commit into from
Aug 21, 2024

Conversation

Hlongyu
Copy link
Contributor

@Hlongyu Hlongyu commented Aug 17, 2024

src/CMakeLists.txt Outdated Show resolved Hide resolved
@lfreist
Copy link
Owner

lfreist commented Aug 18, 2024

Do you know, why the static postfix is necessary on windows? Shouldn't the .dll/.lib file extensions be sufficient to indicate static and dynamic builds?

@Hlongyu
Copy link
Contributor Author

Hlongyu commented Aug 18, 2024

Do you know, why the static postfix is necessary on windows? Shouldn't the .dll/.lib file extensions be sufficient to indicate static and dynamic builds?

On the Windows platform, it's true that 'static' is not needed in the naming of static libraries. However, I noticed that Ninja seems to compile both dynamic and static libraries simultaneously which use same OUTPUT_NANE, and I misunderstood the meaning of OUTPUT_NAME. Adding '_static' was a mistake; I'll fix it tomorrow.

@Hlongyu
Copy link
Contributor Author

Hlongyu commented Aug 18, 2024

I think we need an option to use shared or static.
Like https://github.com/recp/cglm/blob/48839a38a14a653c233693fa911348ce58d57167/CMakeLists.txt#L14

@lfreist
Copy link
Owner

lfreist commented Aug 19, 2024

Thank you! One last thing: The system_info_standalone target must be removed from the tests.

@lfreist lfreist merged commit cef8edf into lfreist:main Aug 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants