Skip to content

Commit

Permalink
remove standalone visual studio solutions
Browse files Browse the repository at this point in the history
  • Loading branch information
@lexxmark
lexxmark committed Jan 10, 2022
1 parent b2a94ad commit 1176da2
Show file tree
Hide file tree
Showing 14 changed files with 0 additions and 3,449 deletions.
297 changes: 0 additions & 297 deletions VS2017/common_lib/common_lib.vcxproj
View file

This file was deleted.

648 changes: 0 additions & 648 deletions VS2017/common_lib/common_lib.vcxproj.filters
View file

This file was deleted.

188 changes: 0 additions & 188 deletions VS2017/win_bison/win_bison.vcxproj
View file

This file was deleted.

Loading

4 comments on commit 1176da2

@GitMensch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use cmake, how can I compile and debug this - or is it to be going "binary only" then?

@lexxmark
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recent changes from #82 don't have proper updates for handmade VS projects.

I just run buildVS2019.bat and then open VS solution generated by CMake.

If you require those handmade projects let's ask @yjh-styx to update them as well.

@Croydon
Copy link
Contributor

@Croydon Croydon commented on 1176da2 Jan 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just run buildVS2019.bat and then open VS solution generated by CMake.

Either that or if you use a recent VS version you can open the CMake project directly: https://docs.microsoft.com/en-us/cpp/build/cmake-projects-in-visual-studio?view=msvc-170

@GitMensch
Copy link
Collaborator

@GitMensch GitMensch commented on 1176da2 Jan 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening it directly only works if you have:

  • a "recent version of Visual Studio" (VS2015+ - but that's a dependency for WinFlexBison in any case)
  • cmake installed

With the existing solutions, which actually got a fix by @yjh-styx in his commit, you can just have the build tools installed and run msbuild against the solution files - neither an IDE nor cmake is necessary, vs2017 works (I think 2015 did work, too, but that got deleted before - which is not that a big issue as you can manually downgrade the 2017 one to 2015.

Please sign in to comment.