Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add email address validation utilities #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add email address validation utilities #7

wants to merge 2 commits into from

Conversation

tjlevel12
Copy link

Fixes #4

@tjlevel12 tjlevel12 requested a review from matthiaswh September 9, 2020 21:03
guruofgentoo
guruofgentoo requested changes Feb 1, 2021
View reviewed changes
Copy link
Member

@guruofgentoo guruofgentoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the notes, when we get usage ironed out, we should add to the readme.

keg_mail/content.py Show resolved Hide resolved
keg_mail/content.py Outdated Show resolved Hide resolved
keg_mail/content.py Outdated Show resolved Hide resolved
@tjlevel12
Update validation per PR review
1c9777d 
 * Extract suggestions method to allow developer access to suggestions
 * Expand test coverage
 * Remove unused import
 * Update the readme

Refs GH-4
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #7 (1c9777d) into master (67976e2) will increase coverage by 1.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   86.82%   87.82%   +1.00%     
==========================================
  Files          11       11              
  Lines         607      657      +50     
  Branches       48       50       +2     
==========================================
+ Hits          527      577      +50     
  Misses         65       65              
  Partials       15       15
Impacted Files Coverage Δ
keg_mail/content.py 84.28% <100.00%> (+6.28%) ⬆️
keg_mail/tests/test_content.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67976e2...1c9777d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiaswh matthiaswh matthiaswh approved these changes

@guruofgentoo guruofgentoo Awaiting requested review from guruofgentoo

Assignees

@matthiaswh matthiaswh

@tjlevel12 tjlevel12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate email address
3 participants
@tjlevel12 @matthiaswh @guruofgentoo