Change Get() API #990
Merged
Change Get() API #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop/v3 #990 +/- ##
=============================================
Coverage ? 67.87%
=============================================
Files ? 93
Lines ? 14384
Branches ? 0
=============================================
Hits ? 9763
Misses ? 3637
Partials ? 984 ☔ View full report in Codecov by Sentry. |
lestrrat
added a commit
that referenced
this pull request
Oct 17, 2023
* Chage Get(string) (interface{}, bool) to Get(string, interface{}) error
* fix example code
* run go mod tidy
* more bazel tweaks
* Documentation fixes
* Generate jws docs
* fix go.mod
lestrrat
added a commit
that referenced
this pull request
Oct 20, 2023
* Chage Get(string) (interface{}, bool) to Get(string, interface{}) error
* fix example code
* run go mod tidy
* more bazel tweaks
* Documentation fixes
* Generate jws docs
* fix go.mod
lestrrat
added a commit
that referenced
this pull request
Oct 27, 2023
* Chage Get(string) (interface{}, bool) to Get(string, interface{}) error
* fix example code
* run go mod tidy
* more bazel tweaks
* Documentation fixes
* Generate jws docs
* fix go.mod
lestrrat
added a commit
that referenced
this pull request
Oct 31, 2023
* Chage Get(string) (interface{}, bool) to Get(string, interface{}) error
* fix example code
* run go mod tidy
* more bazel tweaks
* Documentation fixes
* Generate jws docs
* fix go.mod
lestrrat
added a commit
that referenced
this pull request
Oct 31, 2023
* Chage Get(string) (interface{}, bool) to Get(string, interface{}) error
* fix example code
* run go mod tidy
* more bazel tweaks
* Documentation fixes
* Generate jws docs
* fix go.mod
lestrrat
added a commit
that referenced
this pull request
Oct 31, 2023
* s{/v2/}{/v3}g
* Add v3 to workflows
* more s{v2}{v3}g
* a few more v2 -> v3
* tweak for v3
* tweaks for v3
* Change Get() API (#990)
* Chage Get(string) (interface{}, bool) to Get(string, interface{}) error
* fix example code
* run go mod tidy
* more bazel tweaks
* Documentation fixes
* Generate jws docs
* fix go.mod
* [WIP] Make JWK Key Parsing pluggable (#991)
* s{/v2/}{/v3}g
* Make the probe phase generic, and allow multiple parsers
* panic if default probe registration fails
* Fix documentation
* tweak
* tweak go.mod
* rip out ECDSA specific stuff into its own package
* appease linter
* Add missing file
* Reinstate the relevant changes from 81ba77f
* Update bazel files
* Add missing bazel file
* docs and locks around keyParsers
* docs
* Remove x25519, use crypto/ecdh
* Update go versions to use
* Update version
* remove toolchain directive
* Run make tidy + gazelle-update-repos
* Remove iterators (#999)
* First pass removing iterators from jwk
* Remove iterators from jwe, remove Range
* remove iterate from jws
* Remove iterate from jwt
* Remove remaining iterator from jws
* Remove iterators from jwk
* remove more references to iterators and makePairs
* fix lint
* Fix jwk.Set example
* deterministic token serialization
* remove iterate from cmd
* Rip out iterator library
* do away with context.Context
* appease linter
* Remove ctx from jws
* Add incomplete list of changes
* Fix after rebase
* Allow registering a constructor for RegisterCustomField
* appease linter and add docs
* Add tests in JWE, tweak docs
* Add to JWK
* appease linter
* Fix to use "portable" versions
* Add it to jws
* Add example
lestrrat
added a commit
that referenced
this pull request
Dec 6, 2023
* Chage Get(string) (interface{}, bool) to Get(string, interface{}) error
* fix example code
* run go mod tidy
* more bazel tweaks
* Documentation fixes
* Generate jws docs
* fix go.mod
lestrrat
added a commit
that referenced
this pull request
Dec 6, 2023
* s{/v2/}{/v3}g
* Add v3 to workflows
* more s{v2}{v3}g
* a few more v2 -> v3
* tweak for v3
* tweaks for v3
* Change Get() API (#990)
* Chage Get(string) (interface{}, bool) to Get(string, interface{}) error
* fix example code
* run go mod tidy
* more bazel tweaks
* Documentation fixes
* Generate jws docs
* fix go.mod
* [WIP] Make JWK Key Parsing pluggable (#991)
* s{/v2/}{/v3}g
* Make the probe phase generic, and allow multiple parsers
* panic if default probe registration fails
* Fix documentation
* tweak
* tweak go.mod
* rip out ECDSA specific stuff into its own package
* appease linter
* Add missing file
* Reinstate the relevant changes from 81ba77f
* Update bazel files
* Add missing bazel file
* docs and locks around keyParsers
* docs
* Remove x25519, use crypto/ecdh
* Update go versions to use
* Update version
* remove toolchain directive
* Run make tidy + gazelle-update-repos
* Remove iterators (#999)
* First pass removing iterators from jwk
* Remove iterators from jwe, remove Range
* remove iterate from jws
* Remove iterate from jwt
* Remove remaining iterator from jws
* Remove iterators from jwk
* remove more references to iterators and makePairs
* fix lint
* Fix jwk.Set example
* deterministic token serialization
* remove iterate from cmd
* Rip out iterator library
* do away with context.Context
* appease linter
* Remove ctx from jws
* Add incomplete list of changes
* Fix after rebase
* Allow registering a constructor for RegisterCustomField
* appease linter and add docs
* Add tests in JWE, tweak docs
* Add to JWK
* appease linter
* Fix to use "portable" versions
* Add it to jws
* Add example
lestrrat
added a commit
that referenced
this pull request
Jan 11, 2024
* Chage Get(string) (interface{}, bool) to Get(string, interface{}) error
* fix example code
* run go mod tidy
* more bazel tweaks
* Documentation fixes
* Generate jws docs
* fix go.mod
lestrrat
added a commit
that referenced
this pull request
Jan 11, 2024
* s{/v2/}{/v3}g
* Add v3 to workflows
* more s{v2}{v3}g
* a few more v2 -> v3
* tweak for v3
* tweaks for v3
* Change Get() API (#990)
* Chage Get(string) (interface{}, bool) to Get(string, interface{}) error
* fix example code
* run go mod tidy
* more bazel tweaks
* Documentation fixes
* Generate jws docs
* fix go.mod
* [WIP] Make JWK Key Parsing pluggable (#991)
* s{/v2/}{/v3}g
* Make the probe phase generic, and allow multiple parsers
* panic if default probe registration fails
* Fix documentation
* tweak
* tweak go.mod
* rip out ECDSA specific stuff into its own package
* appease linter
* Add missing file
* Reinstate the relevant changes from 81ba77f
* Update bazel files
* Add missing bazel file
* docs and locks around keyParsers
* docs
* Remove x25519, use crypto/ecdh
* Update go versions to use
* Update version
* remove toolchain directive
* Run make tidy + gazelle-update-repos
* Remove iterators (#999)
* First pass removing iterators from jwk
* Remove iterators from jwe, remove Range
* remove iterate from jws
* Remove iterate from jwt
* Remove remaining iterator from jws
* Remove iterators from jwk
* remove more references to iterators and makePairs
* fix lint
* Fix jwk.Set example
* deterministic token serialization
* remove iterate from cmd
* Rip out iterator library
* do away with context.Context
* appease linter
* Remove ctx from jws
* Add incomplete list of changes
* Fix after rebase
* Allow registering a constructor for RegisterCustomField
* appease linter and add docs
* Add tests in JWE, tweak docs
* Add to JWK
* appease linter
* Fix to use "portable" versions
* Add it to jws
* Add example
lestrrat
added a commit
that referenced
this pull request
Feb 19, 2024
* Chage Get(string) (interface{}, bool) to Get(string, interface{}) error
* fix example code
* run go mod tidy
* more bazel tweaks
* Documentation fixes
* Generate jws docs
* fix go.mod
lestrrat
added a commit
that referenced
this pull request
Feb 19, 2024
* s{/v2/}{/v3}g
* Add v3 to workflows
* more s{v2}{v3}g
* a few more v2 -> v3
* tweak for v3
* tweaks for v3
* Change Get() API (#990)
* Chage Get(string) (interface{}, bool) to Get(string, interface{}) error
* fix example code
* run go mod tidy
* more bazel tweaks
* Documentation fixes
* Generate jws docs
* fix go.mod
* [WIP] Make JWK Key Parsing pluggable (#991)
* s{/v2/}{/v3}g
* Make the probe phase generic, and allow multiple parsers
* panic if default probe registration fails
* Fix documentation
* tweak
* tweak go.mod
* rip out ECDSA specific stuff into its own package
* appease linter
* Add missing file
* Reinstate the relevant changes from 81ba77f
* Update bazel files
* Add missing bazel file
* docs and locks around keyParsers
* docs
* Remove x25519, use crypto/ecdh
* Update go versions to use
* Update version
* remove toolchain directive
* Run make tidy + gazelle-update-repos
* Remove iterators (#999)
* First pass removing iterators from jwk
* Remove iterators from jwe, remove Range
* remove iterate from jws
* Remove iterate from jwt
* Remove remaining iterator from jws
* Remove iterators from jwk
* remove more references to iterators and makePairs
* fix lint
* Fix jwk.Set example
* deterministic token serialization
* remove iterate from cmd
* Rip out iterator library
* do away with context.Context
* appease linter
* Remove ctx from jws
* Add incomplete list of changes
* Fix after rebase
* Allow registering a constructor for RegisterCustomField
* appease linter and add docs
* Add tests in JWE, tweak docs
* Add to JWK
* appease linter
* Fix to use "portable" versions
* Add it to jws
* Add example
lestrrat
added a commit
that referenced
this pull request
Mar 9, 2024
* Chage Get(string) (interface{}, bool) to Get(string, interface{}) error
* fix example code
* run go mod tidy
* more bazel tweaks
* Documentation fixes
* Generate jws docs
* fix go.mod
lestrrat
added a commit
that referenced
this pull request
Mar 9, 2024
* s{/v2/}{/v3}g
* Add v3 to workflows
* more s{v2}{v3}g
* a few more v2 -> v3
* tweak for v3
* tweaks for v3
* Change Get() API (#990)
* Chage Get(string) (interface{}, bool) to Get(string, interface{}) error
* fix example code
* run go mod tidy
* more bazel tweaks
* Documentation fixes
* Generate jws docs
* fix go.mod
* [WIP] Make JWK Key Parsing pluggable (#991)
* s{/v2/}{/v3}g
* Make the probe phase generic, and allow multiple parsers
* panic if default probe registration fails
* Fix documentation
* tweak
* tweak go.mod
* rip out ECDSA specific stuff into its own package
* appease linter
* Add missing file
* Reinstate the relevant changes from 81ba77f
* Update bazel files
* Add missing bazel file
* docs and locks around keyParsers
* docs
* Remove x25519, use crypto/ecdh
* Update go versions to use
* Update version
* remove toolchain directive
* Run make tidy + gazelle-update-repos
* Remove iterators (#999)
* First pass removing iterators from jwk
* Remove iterators from jwe, remove Range
* remove iterate from jws
* Remove iterate from jwt
* Remove remaining iterator from jws
* Remove iterators from jwk
* remove more references to iterators and makePairs
* fix lint
* Fix jwk.Set example
* deterministic token serialization
* remove iterate from cmd
* Rip out iterator library
* do away with context.Context
* appease linter
* Remove ctx from jws
* Add incomplete list of changes
* Fix after rebase
* Allow registering a constructor for RegisterCustomField
* appease linter and add docs
* Add tests in JWE, tweak docs
* Add to JWK
* appease linter
* Fix to use "portable" versions
* Add it to jws
* Add example
lestrrat
added a commit
that referenced
this pull request
Sep 24, 2024
* Chage Get(string) (interface{}, bool) to Get(string, interface{}) error
* fix example code
* run go mod tidy
* more bazel tweaks
* Documentation fixes
* Generate jws docs
* fix go.mod
lestrrat
added a commit
that referenced
this pull request
Sep 24, 2024
* s{/v2/}{/v3}g
* Add v3 to workflows
* more s{v2}{v3}g
* a few more v2 -> v3
* tweak for v3
* tweaks for v3
* Change Get() API (#990)
* Chage Get(string) (interface{}, bool) to Get(string, interface{}) error
* fix example code
* run go mod tidy
* more bazel tweaks
* Documentation fixes
* Generate jws docs
* fix go.mod
* [WIP] Make JWK Key Parsing pluggable (#991)
* s{/v2/}{/v3}g
* Make the probe phase generic, and allow multiple parsers
* panic if default probe registration fails
* Fix documentation
* tweak
* tweak go.mod
* rip out ECDSA specific stuff into its own package
* appease linter
* Add missing file
* Reinstate the relevant changes from 81ba77f
* Update bazel files
* Add missing bazel file
* docs and locks around keyParsers
* docs
* Remove x25519, use crypto/ecdh
* Update go versions to use
* Update version
* remove toolchain directive
* Run make tidy + gazelle-update-repos
* Remove iterators (#999)
* First pass removing iterators from jwk
* Remove iterators from jwe, remove Range
* remove iterate from jws
* Remove iterate from jwt
* Remove remaining iterator from jws
* Remove iterators from jwk
* remove more references to iterators and makePairs
* fix lint
* Fix jwk.Set example
* deterministic token serialization
* remove iterate from cmd
* Rip out iterator library
* do away with context.Context
* appease linter
* Remove ctx from jws
* Add incomplete list of changes
* Fix after rebase
* Allow registering a constructor for RegisterCustomField
* appease linter and add docs
* Add tests in JWE, tweak docs
* Add to JWK
* appease linter
* Fix to use "portable" versions
* Add it to jws
* Add example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #826