-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose ways to integrate new key types better #969
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop/v2 #969 +/- ##
=============================================
Coverage ? 71.93%
=============================================
Files ? 95
Lines ? 13855
Branches ? 0
=============================================
Hits ? 9967
Misses ? 3054
Partials ? 834 ☔ View full report in Codecov by Sentry. |
I don't like the API that exposes the hooks for the raw keys. I need to rethink it |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
@@ -728,6 +495,20 @@ func CurveForAlgorithm(alg jwa.EllipticCurveAlgorithm) (elliptic.Curve, bool) { | |||
return ecutil.CurveForAlgorithm(alg) | |||
} | |||
|
|||
// KeySpec is a specification for additional key types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't going to fly. Need to remove
Notes: need to fix x25519 for > go1.20 |
note: if we want to use crypto/ecdh for go >= 1.20. we're going to have to break back compat for x25519.Public/PrivateKeys, as ecdh.PublicKey/ecdh.PublicKey expects to be treated as pointers, whereas previously we used []byte, which meant that we didn't need to carry pointers. Aligning this with crypto/ecdh probably means we need to release v3 |
Addresses #912