Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumped version #2

Closed
wants to merge 23 commits into from
Closed

bumped version #2

wants to merge 23 commits into from

Conversation

ahmednuaman
Copy link

Fixes #1

@nddeluca
Copy link

+1

@cliffano
Copy link

@leonidas , do you mind looking at this PR considering it has lots of changes?

I would like to know the direction where ansible-nvm is moving to regarding nvm install with/without sudo (changed in ahmednuaman@8dfc4f1).
I think it would be better if this role can support nvm installation for both with/without sudo.

Thanks in advance.

@mattwillsher
Copy link

This PR has a number of issues:

  • nvm_path.stat.exists will stop upgrades
  • No defaulting of nvm.profile_file, so the run fails if the example is used and nvm.profile isn't defined
  • If node isn't installed, node -v fails, nvm_node_version doesn't get created so nvm_node_version.stdout.find(nvm.node_version) == -1 fails, causing a fatal error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nvm version
5 participants