Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(edit): let git handle the edit instead of the custom impleme… #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Teamop
Copy link

@Teamop Teamop commented Aug 19, 2019

…ntation
Thoughts about this change:
editor by default opens the notepad or vim, but there's scenarios:

  1. a linux machine without vim,
  2. the message format is not displayed correctly in notepad

so I think it's best to let git to handle all of the cases instead of the custom implemetation.

@leonardoanalista
Copy link
Member

@Teamop no problems at all. As long as we have a similar user experience as now.

Would git allow us to edit the message?
Would we still be able to get the commit done directly when we don't want to edit the message?

@Teamop
Copy link
Author

Teamop commented Jul 14, 2022

@leonardoanalista yes, I used this behavior in my project for 3 years, I didn't meet any errors.

@leonardoanalista
Copy link
Member

I am happy to go ahead with this @Teamop. Let's recap the benefits:

  • Let GIT handle the commit message so it works with machines without vim or with another default Git editor
  • remove some dependencies: editor, temp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants