Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix fvm check #331

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

charles0122
Copy link
Contributor

#312

If fvm is already included in the project, can we consider removing the code that checks for fvm

@charles0122
Copy link
Contributor Author

I have a question, if I have a version of fvm at the beginning, and then I start using sidekick, will there be a conflict, or will sidekick detect that I already have a version and not ask me to set the environment variable?

@charles0122
Copy link
Contributor Author

Another thing is that the fvm version in sidekick is not easy to update. Is it possible to update fvm through shell without built-in fvm?

@charles0122
Copy link
Contributor Author

#311

@aguilaair
Copy link
Collaborator

Yep, we can remove the FVM checking code istself

@charles0122
Copy link
Contributor Author

I was in the process of removing code and saw that Chocolatey and Brew were only used to download fvm, so I thought I'd check their code and remove it as well. If they have other uses, please let me know.

@charles0122
Copy link
Contributor Author

@aguilaair

@charles0122
Copy link
Contributor Author

They can be used to download git, but the download description says to download fvm

@aguilaair
Copy link
Collaborator

Let's keep brew/choco for now, we should update the description though

@aguilaair aguilaair merged commit f5c0ad7 into leoafarias:main Sep 4, 2024
3 checks passed
@charles0122
Copy link
Contributor Author

@aguilaair We can close the related issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants