Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix FormatException caused by '@' in Custom Flutter Version #808

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

franticn
Copy link

As described in the documentation on https://fvm.app/documentation/advanced/custom-version, when we want to manage a custom version of the Flutter SDK in FVM, we need to use custom_ as a prefix for the version. However, it does not support naming conventions that include an @ symbol, such as custom_3.7.0@huawei. This is because previously, the FlutterVersion#parse(String version) method would first attempt to parse a FlutterVersion.release type of FlutterVersion, and would split the string at the @ symbol. This would cause parsing errors for custom version numbers like custom_3.7.0@huawei. Therefore, I have prioritized the parsing of FlutterVersion.custom to ensure that such FlutterVersion can be successfully parsed.

Copy link

vercel bot commented Dec 23, 2024

@franticn is attempting to deploy a commit to the FlutterTools Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant