Skip to content
This repository has been archived by the owner on Sep 29, 2022. It is now read-only.

Commit

Permalink
#234 Remove React and Webpacker
Browse files Browse the repository at this point in the history
  • Loading branch information
nileshtrivedi committed Jan 23, 2021
1 parent 013f485 commit a095afd
Show file tree
Hide file tree
Showing 10 changed files with 10 additions and 30 deletions.
4 changes: 2 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ gem 'memory_profiler'
gem 'flamegraph'
gem 'stackprof'

gem 'webpacker'
gem 'react-rails'
# gem 'webpacker'
# gem 'react-rails'

gem 'oauth' # for goodreads api

Expand Down
20 changes: 0 additions & 20 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,6 @@ GEM
aws-sigv4 (~> 1.1)
aws-sigv4 (1.2.2)
aws-eventstream (~> 1, >= 1.0.2)
babel-source (5.8.35)
babel-transpiler (0.7.0)
babel-source (>= 4.0, < 6)
execjs (~> 2.0)
bcrypt (3.1.16)
bindex (0.8.1)
bootsnap (1.5.1)
Expand Down Expand Up @@ -277,8 +273,6 @@ GEM
rack (>= 1.2.0)
rack-protection (2.1.0)
rack
rack-proxy (0.6.5)
rack
rack-test (1.1.0)
rack (>= 1.0, < 3)
rails (6.1.0)
Expand Down Expand Up @@ -315,12 +309,6 @@ GEM
rb-fsevent (0.10.4)
rb-inotify (0.10.1)
ffi (~> 1.0)
react-rails (2.6.1)
babel-transpiler (>= 0.7.0)
connection_pool
execjs
railties (>= 3.2)
tilt
redcarpet (3.5.1)
redis (4.2.5)
regexp_parser (1.8.2)
Expand All @@ -343,7 +331,6 @@ GEM
selenium-webdriver (3.142.7)
childprocess (>= 0.5, < 4.0)
rubyzip (>= 1.2.2)
semantic_range (2.3.1)
sentry-raven (3.1.1)
faraday (>= 1.0)
sidekiq (5.2.8)
Expand Down Expand Up @@ -422,11 +409,6 @@ GEM
addressable (>= 2.3.6)
crack (>= 0.3.2)
hashdiff (>= 0.4.0, < 2.0.0)
webpacker (5.2.1)
activesupport (>= 5.2)
rack-proxy (>= 0.6.1)
railties (>= 5.2)
semantic_range (>= 2.3.0)
websocket-driver (0.7.3)
websocket-extensions (>= 0.1.0)
websocket-extensions (0.1.5)
Expand Down Expand Up @@ -470,7 +452,6 @@ DEPENDENCIES
puma (= 5.1.1)
rack-mini-profiler
rails
react-rails
redcarpet
sass-rails (= 6.0.0)
sentry-raven
Expand All @@ -491,7 +472,6 @@ DEPENDENCIES
web-console (>= 4.0.1)
webdrivers
webmock (~> 3.9)
webpacker
will_paginate (~> 3.3.0)

RUBY VERSION
Expand Down
2 changes: 1 addition & 1 deletion app/views/decks/practice.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<div class="row">
<div class="col-md-12 mb-4">
<%= react_component("FlashCardPracticeApp", { flash_card: @flash_card.as_json }) %>
<%# react_component("FlashCardPracticeApp", { flash_card: @flash_card.as_json }) %>
</div>
</div>

Expand Down
2 changes: 1 addition & 1 deletion app/views/decks/show.html.slim
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ p

div.row
div.col-md-12.mb-4
= react_component("FlashCardList", {flash_cards: @deck.flash_cards.as_json })
/ react_component("FlashCardList", {flash_cards: @deck.flash_cards.as_json })
2 changes: 1 addition & 1 deletion app/views/flash_cards/index.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<div class="row">
<div class="col-md-12 mb-4">
<%= react_component("FlashCardList", { flash_cards: @flash_cards.as_json }) %>
<%# react_component("FlashCardList", { flash_cards: @flash_cards.as_json }) %>
</div>
</div>

Expand Down
2 changes: 1 addition & 1 deletion app/views/flash_cards/practice.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<div class="row">
<div class="col-md-12 mb-4">
<%= react_component("FlashCardPracticeApp", { flash_card: @flash_card.as_json }) %>
<%# react_component("FlashCardPracticeApp", { flash_card: @flash_card.as_json }) %>
</div>
</div>

Expand Down
4 changes: 2 additions & 2 deletions app/views/layouts/_head_tag.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@
<%= stylesheet_link_tag 'application', media: 'all' %>
<%= javascript_include_tag 'application' %>

<%= javascript_pack_tag 'application' %>
<%# javascript_pack_tag 'application' %>

<%= stylesheet_pack_tag 'application' %>
<%# stylesheet_pack_tag 'application' %>
<!-- Favicon -->
<link rel="shortcut icon" href="/favicon.png" type="image/png">

Expand Down
2 changes: 1 addition & 1 deletion app/views/layouts/application.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
<div class="bg-green-400 text-xs leading-none py-1 text-center text-white" style="width: <%= current_user.onboarding_percentage %>%"><%= current_user.onboarding_percentage %>%</div>
</div>
</a>
<a href="/flash_cards/practice" class="block px-4 py-2 text-sm text-gray-700 hover:bg-gray-100 transition ease-in-out duration-150" role="menuitem">Practice FlashCards</a>
<!-- <a href="/flash_cards/practice" class="block px-4 py-2 text-sm text-gray-700 hover:bg-gray-100 transition ease-in-out duration-150" role="menuitem">Practice FlashCards</a> -->
<a href="/users/<%= current_user.id %>/collections" class="block px-4 py-2 text-sm text-gray-700 hover:bg-gray-100 transition ease-in-out duration-150" role="menuitem">Your Collections</a>
<a href="/users/<%= current_user.id %>/groups" class="block px-4 py-2 text-sm text-gray-700 hover:bg-gray-100 transition ease-in-out duration-150" role="menuitem">Your Groups</a>
<a href="/users/<%= current_user.id %>" class="block px-4 py-2 text-sm text-gray-700 hover:bg-gray-100 transition ease-in-out duration-150" role="menuitem">Your Profile</a>
Expand Down
2 changes: 1 addition & 1 deletion config/initializers/assets.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# Add additional assets to the asset load path.
# Rails.application.config.assets.paths << Emoji.images_path
# Add Yarn node_modules folder to the asset load path.
Rails.application.config.assets.paths << Rails.root.join('node_modules')
# Rails.application.config.assets.paths << Rails.root.join('node_modules')

# Precompile additional assets.
# application.js, application.css, and all non-JS/CSS in the app/assets
Expand Down
File renamed without changes.

0 comments on commit a095afd

Please sign in to comment.