Floated elements with relative positioning #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 72350ac the css position value of the sticky element is being applied to the spacer div. This causes problems if the sticky element has a position of 'relative' and is floated.
Demo: http://jsfiddle.net/eusonic/j5LHW/1/
When the sticky element bottoms out and is given
position: absolute; bottom: 0px;
it will be positioned relative to the spacer div, when it should be positioned relative to its original container. This causes the sticky element to suddenly jump up to its original position when you reach the bottom of the scrolling area.The problem only occurs when the sticky element is floated because otherwise it isn't inside of the spacer div.
My proposed fix is to only apply the sticky element's position value to the spacer if it is absolute. Consider the possible position values: