Skip to content
This repository has been archived by the owner on May 18, 2019. It is now read-only.

Update import_ldraw_ng.py #87

Open
wants to merge 1 commit into
base: rewrite
Choose a base branch
from
Open

Update import_ldraw_ng.py #87

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 1, 2014

  • merging works as it should now
  • added materials (not previously implemented)

- merging works as it should now
- added materials (not previously implemented)
@ghost ghost mentioned this pull request Jun 1, 2014
@virtualrepublic
Copy link

The importer fails with Blender 2.70a. My Snowspeeder reports some errors and another smaller model looks messed up (geometry, colors, smoothing).

import_ldraw_ng_error

@ghost
Copy link
Author

ghost commented Jun 4, 2014

@virtualrepublic I am using 2.70a too and here it works OK (but actually test just shortly with very simple 4 bricks model), can you post/send me your model to see what errors it giving?

also you should know that this code is still just in development rewriten from scratch by other guys and I only added or better said implemented color schema from previous old script v1.1.5 that works for me as I said above + as for the merging I also noticed something wrong with new code cos it left out some part it should not so guys needs to tweak it furthermore, so... ;)

except that I am actually at the same time (or better said now only) working on new version of old v1.1.5implementing right rotation values in Blender GUI where again I already succeded with simple 4 bricks test model but when I load normal big model it messed up giving few errors that I am working on them now... :)

@le717
Copy link
Owner

le717 commented Jun 8, 2014

@bublible Thanks for the PR. I'm a bit swamped right now so I can't look at it yet, but hopefully I can soon. Word of advice, though, for future reference and to help you out later on: If you had to use a hack to make it work, that's OK (although if you can provide details we can try to figure out why you have to bypass the menu item to begin with), but always remove it before your first commit so it does not end up as part of the PR. That's a sure-fire way to not have your changes (even good ones) merged as-is. 😉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants