-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable macOS universal binary builds #3516
Conversation
@jackrobison could you take a look at this when you get a moment? |
@robd003 does using universal builds require 3.9? If so then this is a little more involved - I know aiohttp had some breaking changes. I think it would be nice to update to 3.9 but if possible this can be a separate pr/issue. |
Python 3.9 is required: https://docs.python.org/3/whatsnew/3.9.html#macos-11-0-big-sur-and-apple-silicon-mac-support I can open another pull request to upgrade aiohttp to 3.6.1 and go through the rest of the modules that might need updating. |
@robd003 i started porting SDK to Python 3.9 back in August, you are welcome to pickup where i left off. essentially the issue is that the tests monkey patch certain Python packages and in 3.9 this monkey patching is no longer allowed so the tests fail. See PR: #3404 to get SDK to work on 3.9 would require refactoring these tests. i believe all of the affected tests are in the DHT module, perhaps @jackrobison or @shyba can provide further guidance. |
Awesome! I'll take a look at the PR and see if I can help :) |
this has been moved up in priority and i'm going to pickup the PR i started back in August. we should sync up. are you on lbry discord? |
@eukreign Could you send an invite link to the discord? |
Closed pending Python 3.9 upgrade |
Python 3.9 supports universal2 builds so had to update to that
ref: #3515