Added various images for light and dark mode also fixed svg issue. #6120
Conversation
Signed-off-by: Ajay Singh <[email protected]>
|
🚀 Preview for commit 997abdb at: https://6758565d60435f6227f0395a--layer5.netlify.app |
Signed-off-by: Ajay Singh <[email protected]>
Signed-off-by: Ajay Singh <[email protected]>
|
🚀 Preview for commit cb06ee8 at: https://675862cf3aba0800813f5053--layer5.netlify.app |
|
🚀 Preview for commit bf31c1c at: https://675a4807577d84cf83b2cb1c--layer5.netlify.app |
Signed-off-by: Ajay Singh <[email protected]>
|
🚀 Preview for commit a223d57 at: https://675a4cc74b7dd2c9047354f6--layer5.netlify.app |
Signed-off-by: Ajay Singh <[email protected]>
Signed-off-by: Ajay Singh <[email protected]>
|
🚀 Preview for commit 1d54ea2 at: https://675a55026eb9b79af7a67bbf--layer5.netlify.app |
Signed-off-by: Ajay Singh <[email protected]>
|
🚀 Preview for commit 94c84b3 at: https://675a5c2e4b7dd2dcdf735178--layer5.netlify.app |
Signed-off-by: Ajay Singh <[email protected]>
|
🚀 Preview for commit dbe16d7 at: https://675a691eb7f803f2d960ab50--layer5.netlify.app |
|
@leecalcote Indeed their was a PNG File within this SVG I have fixed it. |
Final Result. |
|
🚀 Preview for commit ce4ee09 at: https://675ba2e46168b35f98b78323--layer5.netlify.app |
|
Looks good @Ajay-singh1, dark and light svg is also working 👍 |
|
@Ajay-singh1 adding it as an agenda item to the meeting minutes. |
There was a problem hiding this comment.
@Ajay-singh1 why this light mode for the aws only? not other ones like GCP and kubernetes? And why only on the one part and not on the whole page we should use dark and light mode images?
|
@sudhanshutech Done! |
Signed-off-by: Ajay Singh <[email protected]>
Ajay-singh1
force-pushed
the
png-test
branch
from
ce4ee09 to
e4805c6
Compare
|
🚀 Preview for commit d10feb7 at: https://6763b7a7cbfd661d050ecd80--layer5.netlify.app |
Signed-off-by: Ajay Singh <[email protected]>
Signed-off-by: Ajay Singh <[email protected]>
|
🚀 Preview for commit 3dcfeb9 at: https://6763cba72fc6d46eb810ba71--layer5.netlify.app |
Signed-off-by: Ajay Singh <[email protected]>
|
🚀 Preview for commit ed8522c at: https://67641fd866069e221f0ebf33--layer5.netlify.app |
Signed-off-by: Ajay Singh <[email protected]>
|
🚀 Preview for commit ab25f0f at: https://676428b6015266389a663dec--layer5.netlify.app |
|
Please update the title of this PR to be more descriptive of its purpose and area of focus. |
Ajay-singh1
changed the title
|
Hello @sudhanshutech @leecalcote I was going through this PR when I saw that there are no GIFs for light mode in the repo, we can add light GIFs for better consistency in the light theme. |
Ajay-singh1
requested review from
sudhanshutech
and removed request for
sudhanshutech
|
🚀 Preview for commit f42e9b4 at: https://6766bd0b44e08b4fb42280b7--layer5.netlify.app |
Signed-off-by: Ajay Singh <[email protected]>
Ajay-singh1
force-pushed
the
png-test
branch
from
f42e9b4 to
d114294
Compare
Ajay-singh1
changed the title
|
🚀 Preview for commit d114294 at: https://6766e34a6ec7d85eb180657d--layer5.netlify.app |
Ajay-singh1
removed request for
mdkaifansari04,
sudhanshutech and
leecalcote
Ajay-singh1
changed the title
|
🚀 Preview for commit 6e4376d at: https://676769966d04b0ed9f3a22a5--layer5.netlify.app |
Description
I have fixed the image issue in which their was a png file within the svg file also I have updated the wrong className so that the necessary property of the CSS is applied.
This PR fixes #5467
Notes for Reviewers
Signed commits