Fix partner slider animation in home page #5966
Conversation
Signed-off-by: Tharanishwaran <[email protected]>
|
🚀 Preview for commit 2632727 at: https://66fd382b2443dcdceace6e39--layer5.netlify.app |
|
@Ashparshp could you please review this PR and let me know if any changes are needed for merging? Thanks! |
|
🚀 Preview for commit 4af26ad at: https://66fee30bd9202c03a4db0e81--layer5.netlify.app |
|
@Tharanishwaran Please add it as an agenda item to the meeting minutes. |
|
🚀 Preview for commit 112035c at: https://67039e7f58a349684fcb776b--layer5.netlify.app |
There was a problem hiding this comment.
Thank you @Tharanishwaran,
Though it looks good to me, could you consider using React.Suspense for lazy loading to smooth out the sudden jumps when content loads? If possible, applying it to the other components would help as well, as it will reduce the jumpy appearance across the pages.
|
Thank you @Ashparshp for suggesting React.Suspense. Would you like me to implement this in this current PR, or should I create a new one for it? I'm happy to do either. Thank you for your guidance |
|
🚀 Preview for commit 143f3e6 at: https://6705370f3e62580795882907--layer5.netlify.app |
| }); | ||
| }); | ||
|
|
||
| Promise.all(imagePromises) |
There was a problem hiding this comment.
why we using promise here? Will any one image anytime fail to load then all images will fail.
There was a problem hiding this comment.
Promises seem to be ironically named. 😆
|
@Tharanishwaran check is failing. // @Ashparshp keep a eye before approving, |
|
@sudhanshutech, It wasn't failing before! I guess he pushed commits again causing fail. |
|
@sudhanshutech the original animation issues - The partner slider was experiencing sudden jumps and glitches during initial load due to images loading asynchronously without proper handling of loading states. @sudhanshutech you're right about the Promise.all issue. Implementing React Suspense should address this concern as well. I'll also fix the failing checks from the recent merge. Thank you both @Ashparshp And @sudhanshutech for your guidance. |
|
🚀 Preview for commit c0d39ea at: https://670692fa067af26bc00ab236--layer5.netlify.app |
Signed-off-by: Tharanishwaran <[email protected]>
|
🚀 Preview for commit 8aa0192 at: https://670698fb4bfebc7f98a84fc7--layer5.netlify.app |
| ))} | ||
| </Slider> | ||
| ) : ( | ||
| <div style={{ textAlign: "center", padding: "20px" }}>Loading partners...</div> |
There was a problem hiding this comment.
we don't need to display a fallback as a message in our homepage this is not good. Do not add a fallback here. keep it as it was earlier and just fix smoothness of transitions
|
@Tharanishwaran any update? |
|
🚀 Preview for commit 8f3574f at: https://67174d463ddfed6c7c4a0fd1--layer5.netlify.app |
@sudhanshu, I'll update the PR to improve the smoothness of the transitions soon today. |
Signed-off-by: Tharanishwaran <[email protected]>
|
@Ashparshp @sudhanshutech could you please review this PR and let me know if any changes are needed ? |
|
🚀 Preview for commit d6a0e6a at: https://6717c77de99ca74fd86bf255--layer5.netlify.app |
Signed-off-by: Tharanishwaran <[email protected]>
|
🚀 Preview for commit fafaa6d at: https://671804a7c2aaed698b3e5597--layer5.netlify.app |
Tharanishwaran
requested review from
miacycle
and removed request for
miacycle
|
🚀 Preview for commit bcf164d at: https://672228218e16a699721975ca--layer5.netlify.app |
Description
This PR fixes #5805 by ensuring smooth animation for the partner slider on the home page.
Notes for Reviewers
Video
Here's a video showcasing the resolved slider animation issue:
Screencast.from.02-10-24.05.24.43.PM.IST.webm
Signed commits