Add quotes around path in case of spaces. #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Windows, add quotes around path in case of spaces.
Update to include quoted path for windows unit test
|
Hello @johnwc, thanks for PR, could you rebase (and force push) your branch on top of |
Bilge
reviewed
Sep 26, 2021
|
|
||
|
|
||
| $phpBin = PHP_BINARY; | ||
| if ($this->isWindows()) { |
There was a problem hiding this comment.
Why should this just be for Windows? Either spaces need quoting when launching a process or they don't. This is not a platform-dependent problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Windows, add quotes around path in case of spaces.