-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.x] Support OAuth2 Server v9 #1734
[13.x] Support OAuth2 Server v9 #1734
Conversation
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
@driesvints this repo doesn't have |
Great work on creating this PR so quickly seeing v9rc just launched a couple of days ago. I know this PR is still a WIP but do you plan to include the new Device Authorization? |
@jayan-blutui thanks.
Not in this PR, as it makes this hard to review. |
Thanks a lot for this PR @hafezdivandari. We should indeed try to support the new Device flow in v13 but let's indeed tackle that in a subsequent PR. |
@@ -16,13 +16,9 @@ jobs: | |||
strategy: | |||
fail-fast: true | |||
matrix: | |||
php: ['8.0', 8.1, 8.2, 8.3] | |||
php: [8.1, 8.2, 8.3] | |||
laravel: [9, 10, 11] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a next PR we may drop Laravel v9 and v10 support as well as PHP 8.1
@driesvints This PR is ready, but it should target |
@hafezdivandari that's okay. We're using a different approach these days. I'll talk to the team to prepare a new major version. Ideally we'd also take in the new device flow (separate PR). Thanks for working on this one! |
@hafezdivandari I retargeted your PR to 13.x now |
@hafezdivandari @driesvints why not to 12.x? |
@siarheipashkevich there's just too many breaking changes in here. @hafezdivandari reminds me: could you make a list of upgrade steps in |
Can someone give me an idea of the full upgrade steps and mark as ready for review? |
@taylorotwell those are already added to the upgrade guide in this PR. The main reason for this new major version is the oauth server v9 bump and the method signature changes. |
@driesvints We are not going to release 13.x immediately after merging this right? I have 1 or 2 PRs for 13.x before release. I don't want to add too many changes at once, that makes this one hard to review. |
@hafezdivandari no I'll wait for those |
@driesvints I guess I'm looking for a general summary of the changes someone will need to make. What changes will a typical Laravel Passport app need to make? Earlier it was mentioned there are too many breaking changes for patch - what are those breaking changes specifically? |
@taylorotwell nothing, just PHP 8.1+ and removed The braking change is that most of the methods signatures are changed. |
Support OAuth2 Server v9.