horizon base path and app url conflicts #1503
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR addresses the issue where Laravel Horizon's
basePath
is incorrectly constructed when theAPP_URL
has a suffix or whenHORIZON_PATH
is not properly handled. This causes 404 errors when accessing Horizon routes like/jobs
and other resources.Solution
window.Horizon.basePath
usingAPP_URL
andHORIZON_PATH
, ensuring that any suffix or prefix is handled correctly.APP_URL
and leading slashes fromHORIZON_PATH
to avoid double slashes in the path.Example Scenarios
APP_URL=https://example.com
andHORIZON_PATH=horizon
results inwindow.Horizon.basePath = 'https://example.com/horizon'
.APP_URL=https://example.com/suffix
andHORIZON_PATH=horizon
results inwindow.Horizon.basePath = 'https://example.com/suffix/horizon'
.APP_URL=https://example.com
andHORIZON_PATH=/horizon
results inwindow.Horizon.basePath = 'https://example.com/horizon'
.Impact
This change ensures that Horizon's base path is constructed correctly for all configurations of
APP_URL
andHORIZON_PATH
, preventing 404 errors and enhancing compatibility for users with custom URL setups.