Show error in console when php artisan:horizon terminates when using …

…more than configured memory
laravel · Feb 20, 2024 · 8fce4fc · 8fce4fc
1 parent 3bf97ef
commit 8fce4fc
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/src/Console/HorizonCommand.php b/src/Console/HorizonCommand.php
@@ -38,7 +38,11 @@ public function handle(MasterSupervisorRepository $masters)
         $environment = $this->option('environment') ?? config('horizon.env') ?? config('app.env');
 
         $master = (new MasterSupervisor($environment))->handleOutputUsing(function ($type, $line) {
-            $this->output->write($line);
+            if ($type === 'error') {
+                $this->components->error($line);
+            } else {
+                $this->output->write($line);
+            }
         });
 
         ProvisioningPlan::get(MasterSupervisor::name())->deploy($environment);

diff --git a/src/Listeners/MonitorMasterSupervisorMemory.php b/src/Listeners/MonitorMasterSupervisorMemory.php
@@ -17,9 +17,13 @@ public function handle(MasterSupervisorLooped $event)
     {
         $master = $event->master;
 
-        if ($master->memoryUsage() > config('horizon.memory_limit', 64)) {
+        $memoryLimit = config('horizon.memory_limit', 64);
+
+        if ($master->memoryUsage() > $memoryLimit) {
             event(new MasterSupervisorOutOfMemory($master));
 
+            $master->output('error', 'Memory limit exceeded: Using '.ceil($master->memoryUsage()).'/'.$memoryLimit.'MB. Consider increasing horizon.memory_limit.');
+
             $master->terminate(12);
         }
     }

diff --git a/tests/Feature/MonitorMasterSupervisorMemoryTest.php b/tests/Feature/MonitorMasterSupervisorMemoryTest.php
@@ -17,6 +17,7 @@ public function test_supervisor_is_terminated_when_using_too_much_memory()
         $master = Mockery::mock(MasterSupervisor::class);
 
         $master->shouldReceive('memoryUsage')->andReturn(192);
+        $master->shouldReceive('output')->once()->with('error', 'Memory limit exceeded: Using 192/64MB. Consider increasing horizon.memory_limit.');
         $master->shouldReceive('terminate')->once()->with(12);
 
         $monitor->handle(new MasterSupervisorLooped($master));