Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope checker NEW Module #23

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Scope checker NEW Module #23

wants to merge 10 commits into from

Conversation

MrJester
Copy link
Collaborator

No description provided.

dependencies: []
description: Compares the hosts table and removes hosts that are not found within
the provided scope document. Scope should be defined within the document either
by single IP or in CIDR notation (eg. 192.168.1.0/24)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not by domain? In web app land, scope is usually by domain rather than IP. Just a thought.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do either..... I supposed network land I usually get an IP scope :). Could do two modules one for IP and one for the domain.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't like the idea of dynamically detecting a scope entry as IP, CIDR, or domain, then applying as needed? You're already doing it for IP and CIDR, so adding another module seems inconsistent, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just felt like a lot of the other modules are broken up based on that at least that is how I have noticed it. Shouldn't be too hard to add in looking at the domains as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this for reading in a domain now within the scope document.

@0x646e78
Copy link
Contributor

I've added a suggestion to the framework repo here lanmaster53/recon-ng#92 (comment) on an alternative approach to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants