Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Some ruff fixes from preview #5420

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ref: Some ruff fixes from preview #5420

wants to merge 2 commits into from
+370 −339

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Dec 24, 2024

Some ruff fixes from preview

@cbornet cbornet requested a review from ogabrielluiz December 24, 2024 11:20
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 24, 2024
ogabrielluiz
ogabrielluiz approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 24, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 24, 2024

CodSpeed Performance Report

Merging #5420 will degrade performances by 67.62%

Comparing cbornet:ruff-rules-preview-8 (7180577) with main (bd7f913)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cbornet:ruff-rules-preview-8 Change
❌ test_get_and_cache_all_types_dict 1 ms 2.5 ms -58.92%
❌ test_load_flows 1.1 ms 3.3 ms -67.62%
⚡ test_setup_llm_caching 2.9 ms 1 ms ×2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbornet @ogabrielluiz