Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix parallel execution of alembic with SQlite #5404

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Dec 23, 2024

Fix parallel execution of alembic with SQlite

@cbornet cbornet requested a review from ogabrielluiz December 23, 2024 15:07
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Dec 23, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Dec 23, 2024
Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #5404 will degrade performances by 52.95%

Comparing cbornet:sqlite-alembic (5da3522) with main (bd7f913)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cbornet:sqlite-alembic Change
test_load_flows 1.1 ms 2.3 ms -52.95%
test_setup_llm_caching 2.9 ms 1.2 ms ×2.5

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Dec 23, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant