Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Use better task cancellation logic #5397

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ref: Use better task cancellation logic #5397

wants to merge 1 commit into from
+5 −10

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Dec 22, 2024 •
edited
Loading

Use better task cancellation logic

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 22, 2024
@cbornet cbornet requested a review from ogabrielluiz December 22, 2024 23:10
@cbornet cbornet changed the title Use better task cancellation logic ref: Use better task cancellation logic Dec 22, 2024
ogabrielluiz
ogabrielluiz approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 23, 2024
@cbornet cbornet enabled auto-merge December 24, 2024 08:56
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 24, 2024

CodSpeed Performance Report

Merging #5397 will improve performances by ×2.5

Comparing cbornet:task-cancel (53b8450) with main (bd7f913)

Summary

⚡ 1 improvements
✅ 14 untouched benchmarks

Benchmarks breakdown

Benchmark main cbornet:task-cancel Change
⚡ test_setup_llm_caching 2.9 ms 1.2 ms ×2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbornet @ogabrielluiz