Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add minimized attribute to components and make chatinput and chatoutput start minimized by default #5374

Merged
merged 13 commits into from
Dec 23, 2024

Conversation

lucaseduoli
Copy link
Collaborator

This pull request includes several changes to improve the formatting and functionality of chat components in the langflow backend. The most important changes include the addition of the minimized attribute to both ChatInput and ChatOutput classes, and the reformatting of code for better readability.

Chat component enhancements:

Attribute validation:

Starter project updates:

@lucaseduoli lucaseduoli self-assigned this Dec 19, 2024
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 19, 2024
@dosubot dosubot bot added the enhancement New feature or request label Dec 19, 2024
@github-actions github-actions bot added bug Something isn't working and removed enhancement New feature or request labels Dec 19, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Dec 19, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Dec 19, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Dec 19, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Dec 19, 2024
Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #5374 will degrade performances by 56.89%

Comparing fix/chat_input_output_minimized (b5b3b8c) with main (c227a9b)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix/chat_input_output_minimized Change
test_get_and_cache_all_types_dict 1.2 ms 2.7 ms -56.89%
test_setup_llm_caching 2.1 ms 1.2 ms +80.47%
test_successful_run_with_output_type_debug 257.9 ms 224.5 ms +14.9%

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 19, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 20, 2024
@github-actions github-actions bot removed the bug Something isn't working label Dec 20, 2024
@github-actions github-actions bot added the bug Something isn't working label Dec 20, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Dec 21, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Dec 23, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Dec 23, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Dec 23, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Dec 23, 2024
@lucaseduoli lucaseduoli added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit bd7f913 Dec 23, 2024
37 checks passed
@lucaseduoli lucaseduoli deleted the fix/chat_input_output_minimized branch December 23, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants