Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add model validator to FlowHeader model and fix response handling #5355

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request enhances the FlowHeader model by adding detailed field descriptions and implementing a model validator to ensure data integrity. Additionally, import statements have been streamlined for better readability. The response handling in the read_flows function has also been updated to utilize the new validation structure, improving data validation and consistency.

…g in flows.py

- Consolidated import statements for better readability.
- Updated the response structure in the  function to utilize  for improved data validation and consistency.
…nd validation

- Updated FlowHeader model to include field descriptions for better clarity and documentation.
- Introduced a model validator to ensure data integrity before processing.
- Streamlined import statements for improved readability.
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Dec 19, 2024
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed enhancement New feature or request labels Dec 19, 2024
Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #5355 will improve performances by 21.41%

Comparing refactor-read-flows (e6643fd) with main (81da524)

Summary

⚡ 2 improvements
✅ 13 untouched benchmarks

Benchmarks breakdown

Benchmark main refactor-read-flows Change
test_successful_run_with_input_type_any 266.9 ms 219.8 ms +21.41%
test_successful_run_with_output_type_any 281.7 ms 248 ms +13.6%

@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Dec 19, 2024
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 19, 2024
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Dec 19, 2024
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 0619ed7 Dec 19, 2024
25 checks passed
@ogabrielluiz ogabrielluiz deleted the refactor-read-flows branch December 19, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants