-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Error handling in loading components/features in Agent Component #5320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Dec 17, 2024
github-actions
bot
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Dec 17, 2024
CodSpeed Performance ReportMerging #5320 will improve performances by 10.44%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (7)
- src/backend/base/langflow/initial_setup/starter_projects/Instagram Copywriter.json: Language not supported
- src/backend/base/langflow/initial_setup/starter_projects/Market Research.json: Language not supported
- src/backend/base/langflow/initial_setup/starter_projects/Research Agent.json: Language not supported
- src/backend/base/langflow/initial_setup/starter_projects/SaaS Pricing.json: Language not supported
- src/backend/base/langflow/initial_setup/starter_projects/Sequential Tasks Agents .json: Language not supported
- src/backend/base/langflow/initial_setup/starter_projects/Simple Agent.json: Language not supported
- src/backend/base/langflow/initial_setup/starter_projects/Travel Planning Agents.json: Language not supported
Comments suppressed due to low confidence (1)
src/backend/base/langflow/components/agents/agent.py:28
- The error message should include the exception message for better debugging. Suggested change: msg = f"Error building {self.agent_llm} language model: {e}"
msg = f"Error building {self.agent_llm} language model"
ogabrielluiz
approved these changes
Dec 18, 2024
ogabrielluiz
force-pushed
the
fix-errorhandling-agents-tools
branch
from
December 18, 2024 01:25
860f207
to
2ba0ba3
Compare
github-actions
bot
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Dec 18, 2024
anovazzi1
pushed a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces logging and error handling improvements to the
AgentComponent
in thelangflow
package. The changes include adding logging for debugging purposes and handling exceptions more gracefully.Key changes include:
Logging and Error Handling Improvements:
logging
module andlogger
fromlangflow.logging
to theagent.py
file. [1] [2]try
block and added logging for errors.try
block and added logging for errors.try
block and added logging for errors, changing the raised exception type fromValueError
toTypeError
.try
block and added logging for errors.