-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move blocking io ops to async method on dbservice init #5291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
This PR changes 10-29 lines, ignoring generated files.
label
Dec 16, 2024
github-actions
bot
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Dec 16, 2024
cbornet
reviewed
Dec 16, 2024
cbornet
requested changes
Dec 16, 2024
CodSpeed Performance ReportMerging #5291 will degrade performances by 19.66%Comparing Summary
Benchmarks breakdown
|
jordanrfrazier
force-pushed
the
fix-blocking-io-ops
branch
from
December 16, 2024 20:25
88a6175
to
8a2cf7e
Compare
github-actions
bot
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Dec 16, 2024
github-actions
bot
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Dec 16, 2024
cbornet
approved these changes
Dec 17, 2024
github-actions
bot
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Dec 17, 2024
ogabrielluiz
added
lgtm
This PR has been approved by a maintainer
and removed
lgtm
This PR has been approved by a maintainer
labels
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves blocking IO operations to an async method to avoid blocking event loop