Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move blocking io ops to async method on dbservice init #5291

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

jordanrfrazier
Copy link
Collaborator

Moves blocking IO operations to an async method to avoid blocking event loop

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 16, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Dec 16, 2024
Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #5291 will degrade performances by 19.66%

Comparing fix-blocking-io-ops (1d7d51c) with main (a97c29f)

Summary

❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-blocking-io-ops Change
test_get_and_cache_all_types_dict 1.1 ms 1.4 ms -19.66%

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Dec 16, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Dec 16, 2024
@ogabrielluiz ogabrielluiz requested a review from cbornet December 16, 2024 21:03
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 17, 2024
@cbornet cbornet enabled auto-merge (squash) December 17, 2024 12:09
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Dec 17, 2024
@ogabrielluiz ogabrielluiz added lgtm This PR has been approved by a maintainer and removed lgtm This PR has been approved by a maintainer labels Dec 17, 2024
@cbornet cbornet merged commit 39b0d6d into main Dec 17, 2024
32 of 33 checks passed
@cbornet cbornet deleted the fix-blocking-io-ops branch December 17, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants