-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(components): Rename StoreMessage to MessageStore for Better Clarity #5009
refactor(components): Rename StoreMessage to MessageStore for Better Clarity #5009
Conversation
@Vigtu same for this one, if you don't mind fixing the merge conflict i'll do a review! |
CodSpeed Performance ReportMerging #5009 will degrade performances by 23.25%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Vigtu
Thanks for the PR!
When changing componentes we shouldn't change the file name AND the name. You must keep one as it is for backwards compatibility.
You should be better off reverting the change to the name attribute.
Also, if you could add tests to this component like you can see in src/backend/tests/unit/components/../test_input_components.py it would be really good.
Thanks!
icon = "save" | ||
name = "StoreMessage" | ||
icon = "message-square-text" | ||
name = "MessageStore" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks backwards compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ogabrielluiz are there any consequences you can see from this PR as it stands now? I want to defer to you on this one. I think the change makes sense, but wondering if there's anything i'm missing beyond what you pointed out already.
- Restore original filename to maintain system compatibility - Ensure consistent file naming across codebase
- Update Output display_name from "Stored Messages" to "Stored Message" - Maintain consistency in singular/plural naming conventions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Updated import statement in __init__.py to reflect the new module name for MessageStoreComponent. - This change improves clarity and consistency in the component naming convention.
Changes in Message Store Component:
Component Rename:
Output Configuration:
Import Updates:
File Rename:
No Functional Changes: