Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: simplify docker build workflow #4294

Merged
merged 7 commits into from
Nov 6, 2024

Conversation

jordanrfrazier
Copy link
Collaborator

@jordanrfrazier jordanrfrazier commented Oct 26, 2024

Docker Build: https://github.com/langflow-ai/langflow/actions/runs/11700357489/job/32584217961

This pull request includes significant updates to the Docker build and push workflows, primarily focusing on enhancing the flexibility and clarity of version and release type handling. The most important changes include renaming and adding new input parameters, updating job steps to accommodate these changes, and refining the tagging and versioning logic.

Enhancements to Input Parameters:

Updates to Job Steps:

Refinements to Tagging and Versioning Logic:

Changes to Release Workflow:

  • Modified the release workflow to use the new main_version and base_version parameters, ensuring that both base and main versions are passed correctly. (.github/workflows/release.yml, .github/workflows/release.ymlL192-R218)

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 26, 2024
@dosubot dosubot bot added the enhancement New feature or request label Oct 26, 2024
@jordanrfrazier jordanrfrazier requested a review from phact October 26, 2024 19:19
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

btw, we can add an entrypoint to the default image if you like

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 27, 2024
@jordanrfrazier
Copy link
Collaborator Author

LGTM

btw, we can add an entrypoint to the default image if you like

@zzzming Any reason you think we'd want to keep the images separate in the future?

@phact
Copy link
Collaborator

phact commented Oct 30, 2024

LGTM
btw, we can add an entrypoint to the default image if you like

@zzzming Any reason you think we'd want to keep the images separate in the future?

Looks like langflow-frontend and langflow-backend have usage, 5k and 6k pulls respectively. Do we want to delete them?

@jordanrfrazier jordanrfrazier force-pushed the docker-build-simplifications branch from 446d466 to bf67c7d Compare November 6, 2024 08:47
@phact
Copy link
Collaborator

phact commented Nov 6, 2024

LGTM
btw, we can add an entrypoint to the default image if you like

@zzzming Any reason you think we'd want to keep the images separate in the future?

Looks like langflow-frontend and langflow-backend have usage, 5k and 6k pulls respectively. Do we want to delete them?

This is addressed in the latest code.

changes LGTM, nightly action passes https://github.com/langflow-ai/langflow/actions/runs/11710303423 +1

@jordanrfrazier jordanrfrazier merged commit 91ccf1f into main Nov 6, 2024
102 of 127 checks passed
@jordanrfrazier jordanrfrazier deleted the docker-build-simplifications branch November 6, 2024 20:38
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants