[DRAFT] update evaluate to be concurrent #1345
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinthornw
reviewed
Dec 19, 2024
| @@ -642,6 +651,61 @@ async def astart(self) -> _AsyncExperimentManager: | |||
| upload_results=self._upload_results, | |||
| ) | |||
|
|
|||
| async def awith_predictions_and_evaluators( | |||
There was a problem hiding this comment.
We could probably do something similar to what we do in the sync version to avoid having to duplicate logic here (basically share a semaphor)
baskaryan
reviewed
Dec 23, 2024
| evaluators = _resolve_evaluators(evaluators) | ||
|
|
||
| if not hasattr(self, "_evaluator_executor"): | ||
| self._evaluator_executor = cf.ThreadPoolExecutor(max_workers=4) |
There was a problem hiding this comment.
ooc where's the 4 come from?
There was a problem hiding this comment.
I copied the value from _ascore - not really sure beyond that
baskaryan
reviewed
Dec 23, 2024
| ) | ||
| async with lock: |
There was a problem hiding this comment.
could we just return the selected_results in _run_single_evaluator and construct the eval_results after the asycio.gather? to avoid needing to lock?
There was a problem hiding this comment.
should be fixed, but someone should check I did it correctly
baskaryan
reviewed
Dec 23, 2024
| { | ||
| name: { | ||
| "presigned_url": value["presigned_url"], | ||
| "reader": io.BytesIO(value["reader"].getvalue()), |
There was a problem hiding this comment.
would love @agola11's input on this bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.