Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix private key pretty print #80

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Fix private key pretty print #80

merged 4 commits into from
Dec 12, 2024

Conversation

danvangeest
Copy link
Contributor

A line was missing from the MLKEM-512 key.
The leading 00 should not have been printed as that's part of the BIT STRING.
Used dumpasn1 tool (Sean had hand jammed it before).

@danvangeest
Fix private key pretty print
aef78b5 
A line was missing from the MLKEM-512 key.
The leading 00 should not have been printed as that's part of the BIT STRING.
@bwesterb
Copy link
Collaborator

Also check out #84

@seanturner seanturner merged commit 12f3ec7 into lamps-wg:main Dec 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanturner seanturner seanturner approved these changes

@bwesterb bwesterb bwesterb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danvangeest @bwesterb @seanturner