generated from martinthomson/internet-draft-template
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text in Security Consideration regarding the benefits of the 64-byte seed format #69
Merged
seanturner
merged 9 commits into
lamps-wg:seanturner-sec-cons
from
dconnolly:seanturner-sec-cons
Nov 4, 2024
Merged
Add text in Security Consideration regarding the benefits of the 64-byte seed format #69
seanturner
merged 9 commits into
lamps-wg:seanturner-sec-cons
from
dconnolly:seanturner-sec-cons
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanturner
reviewed
Oct 24, 2024
Co-authored-by: Sean Turner <[email protected]>
Co-authored-by: Sean Turner <[email protected]>
dconnolly
commented
Oct 24, 2024
dconnolly
commented
Oct 24, 2024
dconnolly
commented
Oct 24, 2024
seanturner
reviewed
Oct 24, 2024
|
seanturner
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
bwesterb
reviewed
Nov 3, 2024
bwesterb
approved these changes
Nov 3, 2024
seanturner
added a commit
that referenced
this pull request
Nov 4, 2024
* Add Security Considerations. Closes #62. * Add text in Security Consideration regarding the benefits of the 64-byte seed format (#69) * Add text in Security Consideration regarding the benefits of the 64-byte seed format * RNG stuff Co-authored-by: Sean Turner <[email protected]> * Protect secret key material Co-authored-by: Sean Turner <[email protected]> * Indent⁻ * Update draft-ietf-lamps-kyber-certificates.md * Point at FIPS 203 randomness / RBG requirements * fixing spaces * Ref KEM binding properties first formalization paper * Wrap a line --------- Co-authored-by: Sean Turner <[email protected]> --------- Co-authored-by: Deirdre Connolly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to what I have suggested for sfluhrer/ml-kem-security-considerations#10. wdyt @bwesterb @seanturner @danvangeest